Skip to content

Fix serialization of repository_names conditions object - #2910

Merged
gmlewis merged 1 commit into
google:masterfrom
nordnet:repo-name-empty
Sep 4, 2023
Merged

Fix serialization of repository_names conditions object#2910
gmlewis merged 1 commit into
google:masterfrom
nordnet:repo-name-empty

Conversation

@ysoldak

@ysoldakysoldak commented Sep 4, 2023

Copy link
Copy Markdown
Contributor

RulesetRepositoryNamesConditionParameters, Include and Exclude fields shall not be omitted when empty.

Fixes: #2909

RulesetRepositoryNamesConditionParameters
Include and Exclude shall not be omitted
@ysoldakysoldak changed the title Fix json serialisation for RepositoryName fieldsFix json serialisation of repository_names conditions objectSep 4, 2023
@ysoldakysoldak changed the title Fix json serialisation of repository_names conditions objectFix serialisation of repository_names conditions objectSep 4, 2023
@codecov

codecovBot commented Sep 4, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2910 (2852e78) into master (5ab57e7) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2910 +/- ##
=======================================
Coverage 98.12% 98.12% =======================================
Files 142 142 Lines 12453 12453 =======================================
Hits 12219 12219 Misses 159 159 Partials 75 75 
Files ChangedCoverage Δ
github/repos_rules.go100.00% <ø> (ø)

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ysoldak !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @WillAbides !
Merging.

@gmlewisgmlewis changed the title Fix serialisation of repository_names conditions objectFix serialization of repository_names conditions objectSep 4, 2023
@gmlewis
gmlewis merged commit 1a6e6fe into google:masterSep 4, 2023
gmlewis pushed a commit to gmlewis/go-github that referenced this pull request Sep 19, 2023
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to create Repo Ruleset if RepositoryName fields are empty

3 participants

@ysoldak@gmlewis@WillAbides