Skip to content

Remove ListServiceHooks - #2917

Merged
gmlewis merged 1 commit into
google:masterfrom
WillAbides:kill-service-hooks
Sep 18, 2023
Merged

Remove ListServiceHooks#2917
gmlewis merged 1 commit into
google:masterfrom
WillAbides:kill-service-hooks

Conversation

@WillAbides

Copy link
Copy Markdown
Contributor

closes#2916

@codecov

codecovBot commented Sep 5, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2917 (e94283e) into master (b700431) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2917 +/- ##
==========================================
- Coverage 98.12% 98.11% -0.01% 
==========================================
Files 142 142 Lines 12453 12439 -14 ==========================================
- Hits 12219 12205 -14 
Misses 159 159 Partials 75 75 
Files ChangedCoverage Δ
github/misc.go100.00% <ø> (ø)

@gmlewisgmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Sep 5, 2023

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @WillAbides !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@valbeatvalbeat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Sep 18, 2023
@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @valbeat !
Merging.

@gmlewis
gmlewis merged commit 0e8dfae into google:masterSep 18, 2023
@WillAbides
WillAbides deleted the kill-service-hooks branch September 18, 2023 13:42
gmlewis pushed a commit to gmlewis/go-github that referenced this pull request Sep 19, 2023
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ListServiceHooks appears to no longer be supported

3 participants

@WillAbides@gmlewis@valbeat