Skip to content

Correct NewEnterpriseClient deprecation message - #2923

Merged
gmlewis merged 1 commit into
google:masterfrom
oschwald:patch-1
Sep 18, 2023
Merged

Correct NewEnterpriseClient deprecation message#2923
gmlewis merged 1 commit into
google:masterfrom
oschwald:patch-1

Conversation

@oschwald

Copy link
Copy Markdown
Contributor

No description provided.

@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@WillAbidesWillAbides left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was my mistake. Thank you for finding and fixing it.

@oschwald

Copy link
Copy Markdown
ContributorAuthor

I signed the CLA.

@WillAbides

Copy link
Copy Markdown
Contributor

I signed the CLA.

Thanks. Just to set your expectations, the primary maintainer is out this week, so there is a good chance this won't get a second review or be merged for a week or so.

@codecov

codecovBot commented Sep 11, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2923 (544b427) into master (fd33b81) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2923 +/- ##
=======================================
Coverage 98.17% 98.17% =======================================
Files 143 143 Lines 12609 12609 =======================================
Hits 12379 12379 Misses 156 156 Partials 74 74 
Files ChangedCoverage Δ
github/github.go98.11% <ø> (ø)

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @oschwald and @WillAbides !
LGTM.
Merging.

@gmlewis
gmlewis merged commit 3c1590d into google:masterSep 18, 2023
gmlewis pushed a commit to gmlewis/go-github that referenced this pull request Sep 19, 2023
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@oschwald@WillAbides@gmlewis