Uh oh!
There was an error while loading. Please reload this page.
Fix SecretScanning API by switching arguments from url to json - #2934
Merged
gmlewis merged 2 commits intoSep 19, 2023
Conversation
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@## master #2934 +/- ##
=======================================
Coverage 98.17% 98.17% =======================================
Files 143 143 Lines 12597 12597 =======================================
Hits 12367 12367 Misses 156 156 Partials 74 74
|
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
gmlewis
commented
Sep 19, 2023
CollaboratorAuthor
Awaiting LGTM+Approval from any other contributor to this repo before merging. |
jentfoo
commented
Sep 19, 2023
Thank you for the help in fixing this @gmlewis! |
gmlewis
commented
Sep 19, 2023
CollaboratorAuthor
jentfoo
approved these changes
Sep 19, 2023
gmlewis
commented
Sep 19, 2023
CollaboratorAuthor
Thank you, @jentfoo ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #2871.
This PR fixes the endpoint:
https://docs.github.com/en/enterprise-server@3.5/rest/secret-scanning/secret-scanning#update-a-secret-scanning-alert
by sending its parameters in the body instead of as URL query parameters.
I was unable to edit #2871 directly, so this is a replacement.
Thank you, @jentfoo for the bug report and initial PR!