Skip to content

Add test for resource JSON marshaling - ActionVariable - #2942

Merged
gmlewis merged 2 commits into
google:masterfrom
ResamVi:master
Oct 1, 2023
Merged

Add test for resource JSON marshaling - ActionVariable#2942
gmlewis merged 2 commits into
google:masterfrom
ResamVi:master

Conversation

@ResamVi

Copy link
Copy Markdown
Contributor

Hello,

this is just another trivial test adding to the 10 year old issue. I hope there is still demand for this.

Helps #55

@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @ResamVi - is this for hacktoberfest credit?
If so, I'll label it as accepted.

@gmlewis

Copy link
Copy Markdown
Collaborator

Please make sure unit tests pass locally first by running go test ./....

@codecov

codecovBot commented Oct 1, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2942 (73ea7e5) into master (d99d3df) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2942 +/- ##
=======================================
Coverage 98.19% 98.19% =======================================
Files 145 145 Lines 12720 12720 =======================================
Hits 12490 12490 Misses 156 156 Partials 74 74 

@ResamVi

ResamVi commented Oct 1, 2023

Copy link
Copy Markdown
ContributorAuthor

Whoops, that was a tad too hasty of me 🙈 . Should be fixed now.

This is indeed for hacktoberfest so I would happily take the accept label :). Thanks for your time!

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ResamVi !
LGTM.
Merging.

@gmlewisgmlewis changed the title Add tests for resource JSON marshaling - ActionVariableAdd test for resource JSON marshaling - ActionVariableOct 1, 2023
@gmlewis
gmlewis merged commit 25309f3 into google:masterOct 1, 2023
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ResamVi@gmlewis