Skip to content

Add json marshaling tests for action usage and OIDC types - #2944

Merged
gmlewis merged 1 commit into
google:masterfrom
rameshgkwd05:json_marshalling_testing
Oct 1, 2023
Merged

Add json marshaling tests for action usage and OIDC types#2944
gmlewis merged 1 commit into
google:masterfrom
rameshgkwd05:json_marshalling_testing

Conversation

@rameshgkwd05

Copy link
Copy Markdown
Contributor

This PR covers JSON marshalling testing for following types (partial fix for #55)

  1. actions_oidc

    1. type OIDCSubjectClaimCustomTemplate
  2. actions_cache

    1. type ActionsCache
    2. type ActionsCacheList
    3. type ActionsCacheUsage
    4. type ActionsCacheUsageList
    5. type TotalCacheUsage
    6. (type ActionsCacheListOptions does not have any json encoding so we have skipped test case for it.)

NOTE for reviewers: This contribution is for hactoberfest credit please label it so. Thanks!

@rameshgkwd05

Copy link
Copy Markdown
ContributorAuthor

Newly added tests are running fine locally
Screenshot 2023-10-01 at 10 06 58 PM

@codecov

codecovBot commented Oct 1, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2944 (fc3e7b5) into master (d99d3df) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2944 +/- ##
=======================================
Coverage 98.19% 98.19% =======================================
Files 145 145 Lines 12720 12720 =======================================
Hits 12490 12490 Misses 156 156 Partials 74 74 

@gmlewisgmlewis changed the title Add json marshalling tests for action usage and OIDC typesAdd json marshaling tests for action usage and OIDC typesOct 1, 2023

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @rameshgkwd05 !
LGTM.
Merging.

@gmlewis
gmlewis merged commit 8cd452b into google:masterOct 1, 2023
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rameshgkwd05@gmlewis