Skip to content

Support options for GetCodeownersErrors - #2953

Merged
gmlewis merged 3 commits into
google:masterfrom
lachlancooper:add-codeowners-options
Oct 10, 2023
Merged

Support options for GetCodeownersErrors#2953
gmlewis merged 3 commits into
google:masterfrom
lachlancooper:add-codeowners-options

Conversation

@lachlancooper

@lachlancooperlachlancooper commented Oct 9, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes#2952

@google-cla

google-claBot commented Oct 9, 2023

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@lachlancooper
lachlancooper marked this pull request as ready for review October 9, 2023 04:01
@codecov

codecovBot commented Oct 9, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2953 (0b6bb05) into master (74db58f) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 0b6bb05 differs from pull request most recent head 456ef85. Consider uploading reports for the commit 456ef85 to get more accurate results

@@ Coverage Diff @@## master #2953 +/- ##
=======================================
Coverage 98.17% 98.17% =======================================
Files 145 145 Lines 12767 12771 +4 =======================================
+ Hits 12534 12538 +4 
Misses 158 158 Partials 75 75
FilesCoverage Δ
github/repos_codeowners.go100.00% <100.00%> (ø)

gmlewis
gmlewis requested changes Oct 9, 2023
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @lachlancooper !

Comment threadgithub/repos_codeowners_test.go
@gmlewisgmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Oct 9, 2023
gmlewis
gmlewis approved these changes Oct 9, 2023
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @lachlancooper !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@exageraldo

exageraldo commented Oct 10, 2023

Copy link
Copy Markdown
Contributor

LGTM 👍🏻

@gmlewis

gmlewis commented Oct 10, 2023

Copy link
Copy Markdown
Collaborator

Thank you, @exageraldo !
Merging.

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Oct 10, 2023
@gmlewis
gmlewis merged commit fb8f20f into google:masterOct 10, 2023
@gmlewisgmlewis mentioned this pull request Oct 11, 2023
Merged
@lachlancooper
lachlancooper deleted the add-codeowners-options branch October 17, 2023 02:50
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
@jlaportebot
Support options for GetCodeownersErrors (google#2953)
cd04b3b
Fixes: google#2952.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewisgmlewisgmlewis approved these changes
+1 more reviewer
@exageraldoexageraldoexageraldo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Supporting ref parameter for GetCodeownersErrors

3 participants

@lachlancooper@exageraldo@gmlewis