Uh oh!
There was an error while loading. Please reload this page.
Add nil check in ErrorResponse.Error method - #2971
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@## master #2971 +/- ##
==========================================
- Coverage 98.11% 98.10% -0.01%
==========================================
Files 149 149 Lines 12790 12796 +6 ==========================================
+ Hits 12549 12554 +5 - Misses 166 167 +1
Partials 75 75
|
Signed-off-by: Rajat Jindal <rajatjindal83@gmail.com>
rajatjindalforce-pushed
the
fix-panic-errorresponse
branch
from
October 23, 2023 16:32
ec14d72 to
caea042Comparegmlewis
approved these changes
Oct 23, 2023
gmlewis
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @rajatjindal !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
WillAbides
approved these changes
Oct 23, 2023
gmlewis
commented
Oct 23, 2023
Collaborator
Thank you, @WillAbides ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes#2970