Skip to content

Fix branch protection request fields - #2977

Merged
gmlewis merged 2 commits into
google:masterfrom
viqueen:bugfix/branch-protection-request-fields
Nov 3, 2023
Merged

Fix branch protection request fields#2977
gmlewis merged 2 commits into
google:masterfrom
viqueen:bugfix/branch-protection-request-fields

Conversation

@viqueen

Copy link
Copy Markdown
Contributor

Fixes#2976

The property Checks on RequiredStatusChecks type is not required according to GitHub api, so using the omitempty tag

@gmlewisgmlewis changed the title bugfix: branch protection request fieldsFix branch protection request fieldsNov 3, 2023
@codecov

codecovBot commented Nov 3, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2977 (23d33dd) into master (5b34ea7) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2977 +/- ##
=======================================
Coverage 98.11% 98.11% =======================================
Files 149 149 Lines 12796 12796 =======================================
Hits 12555 12555 Misses 166 166 Partials 75 75 
FilesCoverage Δ
github/repos.go98.89% <ø> (ø)

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @viqueen !
LGTM.
Merging.

@gmlewis
gmlewis merged commit f643c0f into google:masterNov 3, 2023
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with Branch Protection fields

2 participants

@viqueen@gmlewis