Skip to content

Add support for Required Workflows - #2979

Merged
gmlewis merged 8 commits into
google:masterfrom
nordnet:required-workflows-rulesets
Nov 8, 2023
Merged

Add support for Required Workflows#2979
gmlewis merged 8 commits into
google:masterfrom
nordnet:required-workflows-rulesets

Conversation

@claystation

@claystationclaystation commented Oct 31, 2023

Copy link
Copy Markdown
Contributor

Fixes#2978
Suggestion to add support for Required Workflows in Github API.

@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewisgmlewis changed the title Support for Required WorkflowsAdd support for Required WorkflowsNov 3, 2023
@codecov

codecovBot commented Nov 3, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2979 (7057678) into master (630bfdb) will decrease coverage by 0.03%.
The diff coverage is 83.33%.

@@ Coverage Diff @@## master #2979 +/- ##
==========================================
- Coverage 97.94% 97.92% -0.03% 
==========================================
Files 149 149 Lines 12836 12854 +18 ==========================================
+ Hits 12572 12587 +15 - Misses 188 190 +2 - Partials 76 77 +1 
FilesCoverage Δ
github/repos_rules.go98.85% <83.33%> (-1.15%)⬇️

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @claystation !
After a few tweaks, we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

Comment threadgithub/repos_rules.go Outdated
Comment threadgithub/repos_rules.go Outdated
Comment threadgithub/repos_rules.go Outdated
@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Nov 3, 2023
@claystation

Copy link
Copy Markdown
ContributorAuthor

Hey @gmlewis ! Thanks for the review :) I updated the code to reflect the correct suggestions!

Comment threadgithub/repos_rules.go Outdated
claystationand others added 2 commits November 6, 2023 09:33
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis

Copy link
Copy Markdown
Collaborator

It looks like some gofmt needs to be called, then we should be good to move forward on this PR.

@claystation

Copy link
Copy Markdown
ContributorAuthor

Hey @gmlewis! I did a gofmt and generated files as requested in the check :) Should be good to go now!

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @claystation !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @valbeat !
Merging.

@gmlewis
gmlewis merged commit 14dccc2 into google:masterNov 8, 2023
@claystation
claystation deleted the required-workflows-rulesets branch November 9, 2023 10:00
@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Dec 1, 2023
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Required Workflows in rulesets

3 participants

@claystation@gmlewis@valbeat