Skip to content

Implement Custom Properties - #2986

Merged
gmlewis merged 13 commits into
google:masterfrom
liaodaniel:support_repo_custom_props
Nov 10, 2023
Merged

Implement Custom Properties#2986
gmlewis merged 13 commits into
google:masterfrom
liaodaniel:support_repo_custom_props

Conversation

@liaodaniel

@liaodanielliaodaniel commented Nov 4, 2023

Copy link
Copy Markdown
Contributor

Resolves#2965

@liaodaniel
Create CustomProperty struct
65e9873
@liaodaniel
Add CreateOrUpdateCustomProperty function
ecc77c2
@liaodaniel
Add GetCustomProperty function
93faa5b
@liaodaniel
Add RemoveCustomProperty function
2f48a7d
@liaodaniel
Add GetAllCustomProperties function
9bda84c
@liaodaniel
Add CreateOrUpdateCustomProperties function
d6c57a4
@liaodaniel
Add CreateOrUpdateCustomPropertyValuesForRepos function
d24c1e3
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
@liaodaniel
Add ListCustomPropertyValues function
dc2238b
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
@liaodaniel
Match the ordering with the API docs
05782e5
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
@liaodaniel
Add openapi metadata
0b1aa7b
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
@codecov

codecovBot commented Nov 4, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2986 (74b47ef) into master (887612f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #2986 +/- ##
==========================================
+ Coverage 98.11% 98.13% +0.01% 
==========================================
Files 149 150 +1 Lines 12808 12906 +98 ==========================================
+ Hits 12567 12665 +98 
Misses 166 166 Partials 75 75
FilesCoverage Δ
github/orgs_properties.go100.00% <100.00%> (ø)

gmlewis
gmlewis requested changes Nov 4, 2023
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @liaodaniel!
Just a few minor tweaks, please, and then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

Comment threadgithub/orgs_properties.go
Comment threadgithub/orgs_properties.go Outdated
Comment threadgithub/orgs_properties.go Outdated
Comment threadgithub/orgs_properties.go Outdated
Comment threadgithub/orgs_properties.go Outdated
@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Nov 7, 2023
gmlewis
gmlewis approved these changes Nov 7, 2023
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @liaodaniel !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

Also, can you please switch this PR out of "Draft" mode when you are ready?

@liaodaniel
liaodaniel marked this pull request as ready for review November 7, 2023 23:15
valbeat
valbeat approved these changes Nov 10, 2023
View reviewed changes

@valbeatvalbeat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis

gmlewis commented Nov 10, 2023

Copy link
Copy Markdown
Collaborator

Thank you, @valbeat !
Merging.

@gmlewis
gmlewis merged commit 3b96fb3 into google:masterNov 10, 2023
@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Dec 1, 2023
@gmlewisgmlewis mentioned this pull request Dec 1, 2023
Merged
@chapurlatnchapurlatn mentioned this pull request Jan 31, 2024
Closed
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
@jlaportebot
Implement Custom Properties (google#2986)
a574477
Fixes: google#2965.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewisgmlewisgmlewis approved these changes
+1 more reviewer
@valbeatvalbeatvalbeat approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for Repository Custom Properties

3 participants

@liaodaniel@gmlewis@valbeat