Skip to content

Implement global security advisories API - #2993

Merged
gmlewis merged 6 commits into
google:masterfrom
cpanato:GH-2851
Nov 29, 2023
Merged

Implement global security advisories API#2993
gmlewis merged 6 commits into
google:masterfrom
cpanato:GH-2851

Conversation

@cpanato

@cpanatocpanato commented Nov 17, 2023

Copy link
Copy Markdown
Contributor
  • implement global security advisories API

Fixes: #2851

cc @gmlewis

@cpanato
cpanatoforce-pushed the GH-2851 branch 3 times, most recently from aebb733 to 0a04270CompareNovember 17, 2023 16:58
@cpanatocpanato mentioned this pull request Nov 17, 2023
Closed
@gmlewisgmlewis changed the title implement global security advisories APIImplement global security advisories APINov 17, 2023
gmlewis
gmlewis requested changes Nov 17, 2023
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cpanato. I'm going to stop my code review early here and ask you to remove as many new structs that you've added as possible, and to instead reuse SecurityAdvisory and other related structs as much as possible without all the duplication.

Also, every new exported struct that you add needs a full godoc string.

Comment threadgithub/security_advisories.go Outdated
Comment threadgithub/security_advisories.go Outdated
Comment threadgithub/security_advisories.go Outdated
@cpanato
implement global security advisories API
788c597
Signed-off-by: cpanato <ctadeu@gmail.com>
@codecov

codecovBot commented Nov 18, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (78c6de0) 97.93% compared to head (b0cc2f2) 97.91%.

FilesPatch %Lines
github/security_advisories.go89.28%2 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #2993 +/- ##
==========================================
- Coverage 97.93% 97.91% -0.02% 
==========================================
Files 150 150 Lines 12952 12980 +28 ==========================================
+ Hits 12685 12710 +25 - Misses 190 192 +2 - Partials 77 78 +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpanato
cpanato requested a review from gmlewisNovember 19, 2023 12:35
gmlewis
gmlewis requested changes Nov 19, 2023
View reviewed changes
Comment threadgithub/security_advisories.go Outdated
Comment threadgithub/security_advisories.go Outdated
Comment threadgithub/security_advisories.go Outdated
Comment threadgithub/security_advisories.go Outdated
Comment threadgithub/security_advisories.go Outdated
Comment threadgithub/security_advisories.go Outdated
Comment threadgithub/security_advisories.go Outdated
Comment threadgithub/security_advisories_test.go Outdated
Comment threadgithub/security_advisories_test.go
Comment threadgithub/security_advisories.go Outdated
@cpanato
update based on feedback
1cff3f0
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato

cpanato commented Nov 19, 2023

Copy link
Copy Markdown
ContributorAuthor

@gmlewis thanks so much for your review and sorry about the force-push

gmlewis
gmlewis requested changes Nov 19, 2023
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, two small nits, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

Comment threadgithub/security_advisories.go Outdated
Comment threadgithub/security_advisories_test.go
@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Nov 19, 2023
@cpanato
update based on feedback part II
ea4ee2c
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
cpanato requested a review from gmlewisNovember 20, 2023 13:53
@cpanato

cpanato commented Nov 20, 2023

Copy link
Copy Markdown
ContributorAuthor

@gmlewis Thanks again for your review, PTAL

@cpanato
update godoc comment
2b22e5b
Signed-off-by: cpanato <ctadeu@gmail.com>
gmlewis
gmlewis requested changes Nov 20, 2023
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @cpanato !
LGTM after one tiny nit, after which we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

Comment threadgithub/security_advisories.go Outdated
@cpanato
fix wording
4d9a20d
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
cpanato requested a review from gmlewisNovember 20, 2023 15:25
@cpanato
fix misspell
b0cc2f2
Signed-off-by: cpanato <ctadeu@gmail.com>
gmlewis
gmlewis approved these changes Nov 20, 2023
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @cpanato !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@cpanato

cpanato commented Nov 24, 2023

Copy link
Copy Markdown
ContributorAuthor

@gmlewis checking if you know how long this will take? :)
also, after we merge this when can we have a new release? thanks again

@gmlewis

gmlewis commented Nov 24, 2023

Copy link
Copy Markdown
Collaborator

@cpanato - we rely on volunteers to help maintain this repo. I don't know when another contributor will be available to review this PR before merging. And yes, we should be able to make a new release soon as well.

@cpanato

cpanato commented Nov 24, 2023

Copy link
Copy Markdown
ContributorAuthor

thank you @gmlewis, no worries just checking :)

valbeat
valbeat approved these changes Nov 29, 2023
View reviewed changes

@valbeatvalbeat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Nov 29, 2023
@gmlewis

gmlewis commented Nov 29, 2023

Copy link
Copy Markdown
Collaborator

Thank you, @valbeat !
Merging.

@gmlewis
gmlewis merged commit 9cf8c17 into google:masterNov 29, 2023
@cpanato

cpanato commented Nov 29, 2023

Copy link
Copy Markdown
ContributorAuthor

thanks for all the support

@cpanato
cpanato deleted the GH-2851 branch November 29, 2023 15:43
@gmlewisgmlewis mentioned this pull request Dec 1, 2023
Merged
@gmlewis

gmlewis commented Dec 1, 2023

Copy link
Copy Markdown
Collaborator

@gmlewis checking if you know how long this will take? :) also, after we merge this when can we have a new release? thanks again

Hi @cpanato - this is now released here: https://github.com/google/go-github/releases/tag/v57.0.0
Sorry for the delay.

@cpanato

cpanato commented Dec 2, 2023

Copy link
Copy Markdown
ContributorAuthor

@gmlewis checking if you know how long this will take? :) also, after we merge this when can we have a new release? thanks again

Hi @cpanato - this is now released here: https://github.com/google/go-github/releases/tag/v57.0.0

Sorry for the delay.

No sorry is needed. Thank you for all the work you do here 🎉 and thanks for the release

gmlewis pushed a commit to o-sama/go-github that referenced this pull request Dec 19, 2023
@cpanato@gmlewis
Implement global security advisories API (google#2993)
b0181bb
Fixes: google#2851.
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
@jlaportebot
Implement global security advisories API (google#2993)
9f93710
Fixes: google#2851.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewisgmlewisgmlewis approved these changes
+1 more reviewer
@valbeatvalbeatvalbeat approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support new Get global security advisories API

3 participants

@cpanato@gmlewis@valbeat