Skip to content

Add GetAllCustomPropertyValues for repositories - #3020

Merged
gmlewis merged 2 commits into
google:masterfrom
liaodaniel:support-repo-custom-props
Dec 17, 2023
Merged

Add GetAllCustomPropertyValues for repositories#3020
gmlewis merged 2 commits into
google:masterfrom
liaodaniel:support-repo-custom-props

Conversation

@liaodaniel

@liaodanielliaodaniel commented Dec 5, 2023

Copy link
Copy Markdown
Contributor

Closes#3014.

Signed-off-by: Daniel Liao 10663736+liaodaniel@users.noreply.github.com

@liaodaniel
Add repo GetAllCustomPropertyValues
e555328
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
@liaodanielliaodaniel changed the title Add repo GetAllCustomPropertyValuesAdd GetAllCustomPropertyValues for repositoriesDec 5, 2023
@liaodaniel
liaodaniel marked this pull request as ready for review December 5, 2023 23:16
gmlewis
gmlewis requested changes Dec 6, 2023
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @liaodaniel !
Just a few tweaks, please, then we will be ready for a second LGTM+Approval from any other contributor to this repo before merging.

Comment threadgithub/repos_properties.go
Comment threadgithub/repos_properties.go Outdated
Comment threadgithub/repos_properties.go Outdated
Comment threadgithub/repos_properties.go Outdated
@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Dec 6, 2023
@codecov

codecovBot commented Dec 6, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1e66201) 97.91% compared to head (0c13729) 97.92%.

Additional details and impacted files
@@ Coverage Diff @@## master #3020 +/- ##
=======================================
Coverage 97.91% 97.92% =======================================
Files 150 151 +1 Lines 12980 12993 +13 =======================================
+ Hits 12710 12723 +13 
Misses 192 192 Partials 78 78

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liaodaniel
Address PR comments
0c13729
Signed-off-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
@liaodaniel

liaodaniel commented Dec 6, 2023

Copy link
Copy Markdown
ContributorAuthor

Thank you @gmlewis, need to pay more attention to copying and pasting 😅

gmlewis
gmlewis approved these changes Dec 6, 2023
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @liaodaniel !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

valbeat
valbeat approved these changes Dec 17, 2023
View reviewed changes

@valbeatvalbeat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Dec 17, 2023
@gmlewis

gmlewis commented Dec 17, 2023

Copy link
Copy Markdown
Collaborator

Thank you, @valbeat !
Merging.

@gmlewis
gmlewis merged commit 005e6c8 into google:masterDec 17, 2023
gmlewis pushed a commit to o-sama/go-github that referenced this pull request Dec 19, 2023
@liaodaniel@gmlewis
Add GetAllCustomPropertyValues for repositories (google#3020)
6e03d4e
Fixes: google#3014.
@kazuki-hanaikazuki-hanai mentioned this pull request Jan 10, 2024
Closed
@gmlewisgmlewis mentioned this pull request Jan 10, 2024
Merged
@chapurlatnchapurlatn mentioned this pull request Jan 31, 2024
Closed
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
@jlaportebot
Add GetAllCustomPropertyValues for repositories (google#3020)
2410050
Fixes: google#3014.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewisgmlewisgmlewis approved these changes
+1 more reviewer
@valbeatvalbeatvalbeat approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for Get All Custom Property Values for a Repository

3 participants

@liaodaniel@gmlewis@valbeat