Skip to content

Fix copilot API payload - #3034

Merged
gmlewis merged 3 commits into
google:masterfrom
zetaab:fixcopilotreqcontent
Dec 19, 2023
Merged

Fix copilot API payload#3034
gmlewis merged 3 commits into
google:masterfrom
zetaab:fixcopilotreqcontent

Conversation

@zetaab

@zetaabzetaab commented Dec 19, 2023

Copy link
Copy Markdown
Contributor

small fix to #2973

cc @gmlewis@o-sama

@gmlewisgmlewis changed the title fix copilot api payloadFix copilot API payloadDec 19, 2023
@gmlewis

gmlewis commented Dec 19, 2023

Copy link
Copy Markdown
Collaborator

Investigating why tests are failing...

@gmlewis

gmlewis commented Dec 19, 2023

Copy link
Copy Markdown
Collaborator

Oh, I see... the unit tests need updating.
@zetaab - please make sure unit tests pass on your side... then push the changes (not force-push) to this PR to fix them.
Please see CONTRIBUTING.md step 4 for details. Thanks.

gmlewis
gmlewis requested changes Dec 19, 2023
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @zetaab !

Let's please keep the struct field names matching the JSON field tag names.

I'm not going to mark this as a Breaking API change since this was just introduced within this major version.

Comment threadgithub/copilot.go Outdated
Comment threadgithub/copilot.go Outdated
gmlewis
gmlewis approved these changes Dec 19, 2023
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @zetaab !
LGTM.
Merging after tests pass.

@codecov

codecovBot commented Dec 19, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d6658a) 97.71% compared to head (af72ec5) 97.71%.

Additional details and impacted files
@@ Coverage Diff @@## master #3034 +/- ##
=======================================
Coverage 97.71% 97.71% =======================================
Files 152 152 Lines 13241 13241 =======================================
Hits 12939 12939 Misses 213 213 Partials 89 89

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis
gmlewis merged commit a6f50f1 into google:masterDec 19, 2023
@zetaab
zetaab deleted the fixcopilotreqcontent branch December 19, 2023 21:10
@gmlewisgmlewis mentioned this pull request Jan 10, 2024
Merged
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
@jlaportebot
Fix copilot API payload (google#3034)
282e6fa
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewisgmlewisgmlewis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zetaab@gmlewis