Skip to content

Fix leaked client transport on copy - #3051

Merged
gmlewis merged 1 commit into
google:masterfrom
gmlewis:i3043-leaky-client-transport-copy
Jan 28, 2024
Merged

Fix leaked client transport on copy#3051
gmlewis merged 1 commit into
google:masterfrom
gmlewis:i3043-leaky-client-transport-copy

Conversation

@gmlewis

Copy link
Copy Markdown
Collaborator

Fixes: #3043.

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@codecov

codecovBot commented Jan 16, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9231a0f) 97.71% compared to head (9424530) 97.69%.
Report is 2 commits behind head on master.

FilesPatch %Lines
github/code-scanning.go75.00%2 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #3051 +/- ##
==========================================
- Coverage 97.71% 97.69% -0.03% 
==========================================
Files 152 152 Lines 13241 13253 +12 ==========================================
+ Hits 12939 12948 +9 - Misses 213 215 +2 - Partials 89 90 +1 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Jan 16, 2024
@gmlewis

gmlewis commented Jan 18, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Awaiting LGTM+Approval from any other contributor to this repo before merging.

@fchimpan

Copy link
Copy Markdown
Contributor

Hi, @gmlewis !
Thank you for your implementation.
I have tested it in my local environment and can confirm that it is working correctly.
LGTM 🚀

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Jan 28, 2024
@gmlewis

Copy link
Copy Markdown
CollaboratorAuthor

Thank you, @fchimpan !
Merging.

@gmlewis
gmlewis merged commit 536966d into google:masterJan 28, 2024
@gmlewis
gmlewis deleted the i3043-leaky-client-transport-copy branch January 28, 2024 19:24
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Access token leakage when reusing the client between users

2 participants

@gmlewis@fchimpan