Uh oh!
There was an error while loading. Please reload this page.
Add custom properties on Repository and PushEventRepository - #3065
Merged
Conversation
ContributorAuthor
I added it in the "main" set of properties cause it always present and the concept of custom properties is closed to Topics but please note that I can add a space between Topics and CustomProperties to avoid reformating the previous properties. |
chapurlatn
commented
Jan 31, 2024
ContributorAuthor
Related issue: #3064 |
chapurlatnforce-pushed
the
feat/custom_properties
branch
from
January 31, 2024 14:29
ae9d58a to
de69728CompareCodecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #3065 +/- ##
=======================================
Coverage 97.71% 97.71% =======================================
Files 152 152 Lines 13335 13335 =======================================
Hits 13030 13030 Misses 215 215 Partials 90 90 ☔ View full report in Codecov by Sentry. |
gmlewis
approved these changes
Jan 31, 2024
gmlewis
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @chapurlatn !
LGTM.
Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repository and PushEventRepository updated:
Getters generated.
Scripts fmt, test, link passed.