Skip to content

Allow Installation of Custom Properties Permissions - #3108

Merged
gmlewis merged 3 commits into
google:masterfrom
shellz-n-stuff:master
Mar 24, 2024
Merged

Allow Installation of Custom Properties Permissions#3108
gmlewis merged 3 commits into
google:masterfrom
shellz-n-stuff:master

Conversation

@shellz-n-stuff

Copy link
Copy Markdown
Contributor

Description

This PR allows app installations to request tokens with access to the Org level Custom Properties APIs

Refs

  1. GitHub App installation access tokens
  2. API Docs

@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@shellz-n-stuff

Copy link
Copy Markdown
ContributorAuthor

CLA Signed 🙏

@codecov

codecovBot commented Mar 21, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.87%. Comparing base (2b8c7fa) to head (a4e5e96).
Report is 25 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3108 +/- ##
==========================================
- Coverage 97.72% 92.87% -4.85% 
==========================================
Files 153 170 +17 Lines 13390 11407 -1983 ==========================================
- Hits 13085 10594 -2491 - Misses 215 723 +508 
Partials 90 90 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @shellz-n-stuff !
Please run step 4 of CONTRIBUTING.md and push the changes to this PR.

@shellz-n-stuff

Copy link
Copy Markdown
ContributorAuthor

My bad re-lint/generate. All updated 🙏

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @shellz-n-stuff !
LGTM.
Merging.

@gmlewis
gmlewis merged commit b3e96fd into google:masterMar 24, 2024
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@shellz-n-stuff@gmlewis