Fix pagination for ListCopilotSeats

[alinbalutoiu]

The pagination must be passed as query parameters instead of request body according to the docs.

Currently this is silently failing but the pagination is broken if you've got lots of Copilot users.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.87%. Comparing base (2b8c7fa) to head (8c842e5).
Report is 27 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@## master #3112 +/- ##
==========================================
- Coverage 97.72% 92.87% -4.85% 
==========================================
Files 153 170 +17 Lines 13390 11410 -1980 ==========================================
- Hits 13085 10597 -2488 - Misses 215 723 +508 
Partials 90 90 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gmlewis]

Thank you, @alinbalutoiu !

Before line 587 of copilot_test.go, could you please change those lines from:

testBadOptions(t, methodName, func() (errerror) {
_, _, err=client.Copilot.ListCopilotSeats(ctx, "\n", nil)

to:

opts:=&ListOptions{Page: 2}
testBadOptions(t, methodName, func() (errerror) {
_, _, err=client.Copilot.ListCopilotSeats(ctx, "\n", opts)

That should fix our code coverage problem.

[alinbalutoiu]

Thank you @gmlewis, I missed that initially. Fixed it!

[gmlewis]

Thank you, @alinbalutoiu !
LGTM.
Merging.

[alinbalutoiu]

@gmlewis do you know when this will make into a release version? It would be super helpful to be able to pull a specific version of the library with this fix.

[gmlewis]

@gmlewis do you know when this will make into a release version? It would be super helpful to be able to pull a specific version of the library with this fix.

You can always pull in a specific version using the commit hash:
https://go.dev/wiki/Modules#daily-workflow

Otherwise, we try to release this repo approximately monthly which would be in a couple-ish weeks.