Skip to content

feat: Add missing github enterprise importer and domains meta fields - #3121

Merged
gmlewis merged 1 commit into
google:masterfrom
lrstanley:feature/meta-github-enterprise-importer
Apr 3, 2024
Merged

feat: Add missing github enterprise importer and domains meta fields#3121
gmlewis merged 1 commit into
google:masterfrom
lrstanley:feature/meta-github-enterprise-importer

Conversation

@lrstanley

Copy link
Copy Markdown
Contributor

Adds two of the missing fields, github_enterprise_importer and domains, which are now included with the public meta endpoint. Also fixed some minor capitalization errors.

@google-cla

google-claBot commented Apr 3, 2024

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewisgmlewis changed the title feat: add missing github enterprise importer and domains meta fieldsfeat: Add missing github enterprise importer and domains meta fieldsApr 3, 2024
@codecov

codecovBot commented Apr 3, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.88%. Comparing base (2b8c7fa) to head (3250afd).
Report is 35 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3121 +/- ##
==========================================
- Coverage 97.72% 92.88% -4.84% 
==========================================
Files 153 170 +17 Lines 13390 11423 -1967 ==========================================
- Hits 13085 10610 -2475 - Misses 215 723 +508 
Partials 90 90 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @lrstanley !
LGTM.
Merging.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@lrstanley@gmlewis