Uh oh!
There was an error while loading. Please reload this page.
Query identities associated with organization roles - #3130
Conversation
da27875 to
938e185CompareWrap queries to return the teams and users associated with a specific organization role
938e185 to
c4d9957CompareCodecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #3130 +/- ##
==========================================
- Coverage 97.72% 92.89% -4.83%
==========================================
Files 153 170 +17 Lines 13390 11449 -1941 ==========================================
- Hits 13085 10636 -2449 - Misses 215 723 +508
Partials 90 90 ☔ View full report in Codecov by Sentry. |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @tomfeigin .
It looks like some changes need to be made, and the tests need to be updated to accommodate the pagination options.
No need to force-push, as we always squash & merge.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
gmlewis
left a comment
There was a problem hiding this comment.
WHUPS! Sorry my suggestions were bad... glad you caught them!!!
That will teach me to write a suggestion from memory!!!
Thank you, @tomfeigin !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
| return nil, nil, err | ||
| } | ||
| var teams []*Team |
There was a problem hiding this comment.
I could find "notification_setting" in example response in API docs, but I could not find this field in Team struct.
There was a problem hiding this comment.
This is not relevant to this PR, you can open a new PR which adds fields to the Team struct
gmlewis
commented
May 7, 2024
Thank you, @Sairaviteja27 ! |
Wrap queries to return the teams and users associated with a specific organization role