Skip to content

Query identities associated with organization roles - #3130

Merged
gmlewis merged 2 commits into
google:masterfrom
tomfeigin:list-users-and-teams-assigned-to-roles
May 7, 2024
Merged

Query identities associated with organization roles#3130
gmlewis merged 2 commits into
google:masterfrom
tomfeigin:list-users-and-teams-assigned-to-roles

Conversation

@tomfeigin

Copy link
Copy Markdown
Contributor

Wrap queries to return the teams and users associated with a specific organization role

@tomfeigin
tomfeiginforce-pushed the list-users-and-teams-assigned-to-roles branch from da27875 to 938e185CompareApril 16, 2024 06:47
Wrap queries to return the teams and users associated with a specific
organization role
@tomfeigin
tomfeiginforce-pushed the list-users-and-teams-assigned-to-roles branch from 938e185 to c4d9957CompareApril 16, 2024 06:49
@codecov

codecovBot commented Apr 16, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.89%. Comparing base (2b8c7fa) to head (99ad745).
Report is 41 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3130 +/- ##
==========================================
- Coverage 97.72% 92.89% -4.83% 
==========================================
Files 153 170 +17 Lines 13390 11449 -1941 ==========================================
- Hits 13085 10636 -2449 - Misses 215 723 +508 
Partials 90 90 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tomfeigin .
It looks like some changes need to be made, and the tests need to be updated to accommodate the pagination options.
No need to force-push, as we always squash & merge.

Comment threadgithub/orgs_custom_roles.go Outdated
Comment threadgithub/orgs_custom_roles.go Outdated
Comment threadgithub/orgs_custom_roles.go Outdated
Comment threadgithub/orgs_custom_roles.go Outdated
@tomfeigin
tomfeigin requested a review from gmlewisApril 16, 2024 12:45

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WHUPS! Sorry my suggestions were bad... glad you caught them!!!
That will teach me to write a suggestion from memory!!!

Thank you, @tomfeigin !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Apr 16, 2024
return nil, nil, err
}

var teams []*Team

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could find "notification_setting" in example response in API docs, but I could not find this field in Team struct.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not relevant to this PR, you can open a new PR which adds fields to the Team struct

@Sairaviteja27Sairaviteja27 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @Sairaviteja27 !
Merging.

@gmlewis
gmlewis merged commit 81ff3c9 into google:masterMay 7, 2024
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NeedsReviewPR is awaiting a review before merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tomfeigin@gmlewis@Sairaviteja27