Skip to content

Add support for merge queue ruleset JSON unmarshaling - #3131

Merged
gmlewis merged 5 commits into
google:masterfrom
Matthew-Reidy:master
Apr 19, 2024
Merged

Add support for merge queue ruleset JSON unmarshaling #3131
gmlewis merged 5 commits into
google:masterfrom
Matthew-Reidy:master

Conversation

@Matthew-Reidy

@Matthew-ReidyMatthew-Reidy commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

Fixes: #3098.

Added support for respository ruleset merge_queue in JSON unmarshalling code with accompanying tests

@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewisgmlewis changed the title added support for merge queue ruleset JSON unmarshalling Add support for merge queue ruleset JSON unmarshaling Apr 18, 2024

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Matthew-Reidy !
Just a couple minor tweaks, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

Comment threadAUTHORS Outdated
Comment threadgithub/repos_rules.go Outdated
Comment threadgithub/repos_rules.go Outdated
@codecov

codecovBot commented Apr 18, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.88%. Comparing base (2b8c7fa) to head (db98743).
Report is 41 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3131 +/- ##
==========================================
- Coverage 97.72% 92.88% -4.84% 
==========================================
Files 153 170 +17 Lines 13390 11426 -1964 ==========================================
- Hits 13085 10613 -2472 - Misses 215 723 +508 
Partials 90 90 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Matthew-Reidy

Matthew-Reidy commented Apr 18, 2024

Copy link
Copy Markdown
ContributorAuthor

Sure thing. I'll fix those items shortly

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Matthew-Reidy !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Apr 18, 2024
Comment threadgithub/repos_rules.go Outdated
@liaodaniel

Copy link
Copy Markdown
Contributor

Just a minor comment to update but looks good otherwise

Co-authored-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
@Matthew-Reidy

Copy link
Copy Markdown
ContributorAuthor

changes to that comment have been made

@liaodanielliaodaniel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @liaodaniel !
Merging.

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Apr 19, 2024
@gmlewis
gmlewis merged commit b02f283 into google:masterApr 19, 2024
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Merge Queues break repository ruleset unmarshaling

3 participants

@Matthew-Reidy@liaodaniel@gmlewis