Skip to content

Add Missing Changes Field to Member Event Type. - #3153

Merged
gmlewis merged 1 commit into
google:masterfrom
tayosec:update-member-event-type
Apr 25, 2024
Merged

Add Missing Changes Field to Member Event Type.#3153
gmlewis merged 1 commit into
google:masterfrom
tayosec:update-member-event-type

Conversation

@tayosec

@tayosectayosec commented Apr 25, 2024

Copy link
Copy Markdown
Contributor

Fixes: #3154.

The member webhook event as described by github documentation contains a changes object. https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=edited#member

However, the struct that defines the Member webhook event type is missing the changes object . This PR adds the missing changes object to the MemberEvent type.

The `member` webhook event as described by github documentation contains a `changes` object.
https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=edited#member
This PR adds the missing `changes` object to the `MemberEvent` type.
@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov

codecovBot commented Apr 25, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.88%. Comparing base (2b8c7fa) to head (c190d6b).
Report is 43 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3153 +/- ##
==========================================
- Coverage 97.72% 92.88% -4.84% 
==========================================
Files 153 170 +17 Lines 13390 11426 -1964 ==========================================
- Hits 13085 10613 -2472 - Misses 215 723 +508 
Partials 90 90 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tayosec !
LGTM.
Merging.

@gmlewis
gmlewis merged commit d067824 into google:masterApr 25, 2024
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Webhook MemberEvent Type is Missing Changes Object

2 participants

@tayosec@gmlewis