Skip to content

Allow an empty array of repo ids as a request parameter - #3155

Merged
gmlewis merged 10 commits into
google:masterfrom
Matthew-Reidy:master
Apr 29, 2024
Merged

Allow an empty array of repo ids as a request parameter#3155
gmlewis merged 10 commits into
google:masterfrom
Matthew-Reidy:master

Conversation

@Matthew-Reidy

@Matthew-ReidyMatthew-Reidy commented Apr 26, 2024

Copy link
Copy Markdown
Contributor

Fixes: #3106.

Add extra endpoint function that allows client to pass an empty array of repository ids to the installations/<install_id>/access_tokens endpoint as a parameter. Response lists all repositories in an installation.

@codecov

codecovBot commented Apr 26, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.89%. Comparing base (2b8c7fa) to head (6f4c7c1).
Report is 44 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3155 +/- ##
==========================================
- Coverage 97.72% 92.89% -4.84% 
==========================================
Files 153 170 +17 Lines 13390 11436 -1954 ==========================================
- Hits 13085 10623 -2462 - Misses 215 723 +508 
Partials 90 90 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Matthew-ReidyMatthew-Reidy changed the title issue3106 - Allow an empty array of repo ids as a request parameterAllow an empty array of repo ids as a request parameterApr 26, 2024
Comment threadgithub/apps.go Outdated

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Matthew-Reidy !
One tiny nit so we have complete sentences in our godocs, otherwise LGTM.

Comment threadgithub/apps.go Outdated

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Matthew-Reidy !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Apr 29, 2024
@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Apr 29, 2024
@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @be0x74a !
Merging.

@gmlewis
gmlewis merged commit 108f958 into google:masterApr 29, 2024
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

omitempty tag on InstallationAccessTokenOptions.Repositories masking functionality of GitHub API

3 participants

@Matthew-Reidy@gmlewis@be0x74a