Skip to content

Add support for check private vulnerability reporting endpoint - #3157

Merged
gmlewis merged 10 commits into
google:masterfrom
Sairaviteja27:check-pvt-vuln-report-enabled
May 5, 2024
Merged

Add support for check private vulnerability reporting endpoint#3157
gmlewis merged 10 commits into
google:masterfrom
Sairaviteja27:check-pvt-vuln-report-enabled

Conversation

@Sairaviteja27

Copy link
Copy Markdown
Contributor

fixes#3152

@codecov

codecovBot commented May 1, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.89%. Comparing base (2b8c7fa) to head (6e51ef7).
Report is 50 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3157 +/- ##
==========================================
- Coverage 97.72% 92.89% -4.84% 
==========================================
Files 153 170 +17 Lines 13390 11466 -1924 ==========================================
- Hits 13085 10651 -2434 - Misses 215 724 +509 - Partials 90 91 +1 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Sairaviteja27 !

Comment threadgithub/repos.go Outdated
Comment on lines +2406 to +2407
// CheckPrivateReporting represents whether private vulnerability reporting is enabled.
type CheckPrivateReporting struct {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be private since it isn't exposed anywhere to the end-user.

Comment threadgithub/repos.go Outdated
@Sairaviteja27
Sairaviteja27 marked this pull request as draft May 3, 2024 17:36
Comment threadgithub/repos.go Outdated
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Sairaviteja27 !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label May 3, 2024
@Sairaviteja27
Sairaviteja27 marked this pull request as ready for review May 3, 2024 17:55
@Sairaviteja27

Copy link
Copy Markdown
ContributorAuthor

@gmlewis I think code coverage check is failing. Could you suggest if I should I add tests in other methods?

@gmlewis

Copy link
Copy Markdown
Collaborator

@gmlewis I think code coverage check is failing. Could you suggest if I should I add tests in other methods?

Don't worry about that. We've had some weirdness with codecov lately and I've made two reports with the problems we've seen and don't have any resolution yet. Thanks, though.

@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @be0x74a !
Merging.

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label May 5, 2024
@gmlewis
gmlewis merged commit 5868a66 into google:masterMay 5, 2024
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support new REST API endpoint that evaluates if private vulnerability reporting is enabled

3 participants

@Sairaviteja27@gmlewis@be0x74a