Skip to content

Fix: Propagate context with DownloadContents - #3181

Merged
gmlewis merged 1 commit into
google:masterfrom
HakShak:download-contents-ctx
Jun 11, 2024
Merged

Fix: Propagate context with DownloadContents#3181
gmlewis merged 1 commit into
google:masterfrom
HakShak:download-contents-ctx

Conversation

@HakShak

Copy link
Copy Markdown
Contributor

Main motivation is tracing as this can be the most time consuming operation.

Main motivation is tracing as this can be the most time consuming
operation.
@codecov

codecovBot commented Jun 9, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.90%. Comparing base (2b8c7fa) to head (c29514f).
Report is 67 commits behind head on master.

FilesPatch %Lines
github/repos_contents.go50.00%2 Missing and 2 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #3181 +/- ##
==========================================
- Coverage 97.72% 92.90% -4.82% 
==========================================
Files 153 171 +18 Lines 13390 11548 -1842 ==========================================
- Hits 13085 10729 -2356 - Misses 215 726 +511 - Partials 90 93 +3 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewisgmlewis changed the title fix: propagate context with DownloadContentsFix: Propagate context with DownloadContentsJun 9, 2024
@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Jun 9, 2024

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @HakShak !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@tomfeigintomfeigin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Jun 11, 2024
@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @tomfeigin !
Merging.

@gmlewis
gmlewis merged commit f78378d into google:masterJun 11, 2024
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@HakShak@gmlewis@tomfeigin