Uh oh!
There was an error while loading. Please reload this page.
Add support in rulesets for including or excluding repos based on properties - #3194
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #3194 +/- ##
==========================================
- Coverage 97.72% 92.90% -4.82%
==========================================
Files 153 171 +18 Lines 13390 11548 -1842 ==========================================
- Hits 13085 10729 -2356 - Misses 215 726 +511 - Partials 90 93 +3 ☔ View full report in Codecov by Sentry. |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @claystation !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
claystation
commented
Jun 26, 2024
@gmlewis i had to fix a small bug by removing |
gmlewis
commented
Jun 26, 2024
Thank you, @ysoldak and @claystation ! |
Github recently introduced Repository Properties. Rulesets can include or exclude repositories based on these properties.
The PR implements those conditions.
According to Github API docs:
https://docs.github.com/en/rest/orgs/rules?apiVersion=2022-11-28#create-an-organization-repository-ruleset
Changed comment on
RulesetConditionsstruct to say either use Name, ID OR repo property. The docs have not been super clear on this but i assume so because when creating rulesets trough UI you can either select repositories based on name or on property.Please let me know what you think!