Skip to content

Add support for App Callback URLs - #3204

Merged
gmlewis merged 5 commits into
google:masterfrom
Roming22:3203-add-callback-url
Jul 10, 2024
Merged

Add support for App Callback URLs#3204
gmlewis merged 5 commits into
google:masterfrom
Roming22:3203-add-callback-url

Conversation

@Roming22

Copy link
Copy Markdown
Contributor

Fixes: #3203

Comment threadscrape/apps.go Outdated
//Required. The homepage of your GitHub App.
URL *string `json:"url,omitempty"`
// The full URL of the endpoint to authenticate users via the GitHub App.
CallbackURL *string `json:"url,omitempty"`

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes no sense to me, based on line 117 above it.
Note that both fields have identical JSON bindings, which means they get mapped to the same thing:

	URL *string `json:"url,omitempty"`
CallbackURL *string `json:"url,omitempty"`

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're absolutely right. I should have copied the code from my test, but didn't.
It's now fixed.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Roming22 !
Could I please trouble you to add the GitHub API Docs URL as a comment to this code that shows where this is documented?
I know this is the scrape directory, but it would be nice to have a reference to it.
Thanks again!

@codecov

codecovBot commented Jul 10, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.92%. Comparing base (2b8c7fa) to head (d7769ed).
Report is 79 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3204 +/- ##
==========================================
- Coverage 97.72% 92.92% -4.80% 
==========================================
Files 153 171 +18 Lines 13390 11582 -1808 ==========================================
- Hits 13085 10763 -2322 - Misses 215 726 +511 - Partials 90 93 +3 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Roming22

Copy link
Copy Markdown
ContributorAuthor

Thank you, @Roming22 ! Could I please trouble you to add the GitHub API Docs URL as a comment to this code that shows where this is documented? I know this is the scrape directory, but it would be nice to have a reference to it. Thanks again!

I do not know where, or whether, it is documented. I look at the surrounding fields and made a lucky guess.

@Roming22

Copy link
Copy Markdown
ContributorAuthor

Found it!
Link added as a comment. Please check that it looks like the right one to you too.

Comment threadscrape/apps.go
@gmlewisgmlewis changed the title Add support for App Callback URL (#3203)Add support for App Callback URLs (#3203)Jul 10, 2024
Comment threadscrape/apps.go Outdated
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Roming22 !
LGTM.
Merging.

@gmlewisgmlewis changed the title Add support for App Callback URLs (#3203)Add support for App Callback URLsJul 10, 2024
@gmlewis
gmlewis merged commit 0c1bfb4 into google:masterJul 10, 2024
@Roming22

Copy link
Copy Markdown
ContributorAuthor

Thanks for the support @gmlewis!

Is there an ETA for the next release?

@gmlewis

Copy link
Copy Markdown
Collaborator

It looks like it is about time. I'll work on it.

@gmlewis

Copy link
Copy Markdown
Collaborator

This is now available here: https://github.com/google/go-github/releases/tag/v63.0.0

jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: Set the callback URL at app creation time

2 participants

@Roming22@gmlewis