Skip to content

Add doc for NewPullRequest - #3208

Merged
gmlewis merged 1 commit into
google:masterfrom
kevinburkesegment:doc-changes
Jul 16, 2024
Merged

Add doc for NewPullRequest#3208
gmlewis merged 1 commit into
google:masterfrom
kevinburkesegment:doc-changes

Conversation

@kevinburkesegment

Copy link
Copy Markdown
Contributor

I recently mixed up "Head" and "Base" and the error message was not clear. Add some guidance to help people avoid making the same mistake.

This is copied word for word from the existing Github docs.

I recently mixed up "Head" and "Base" and the error message was not
clear. Add some guidance to help people avoid making the same mistake.
This is copied word for word from the existing Github docs.
@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov

codecovBot commented Jul 15, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.92%. Comparing base (2b8c7fa) to head (f6299f1).
Report is 82 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3208 +/- ##
==========================================
- Coverage 97.72% 92.92% -4.80% 
==========================================
Files 153 171 +18 Lines 13390 11582 -1808 ==========================================
- Hits 13085 10763 -2322 - Misses 215 726 +511 - Partials 90 93 +3 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @kevinburkesegment - would you like to sign the CLA so that I can merge this, or would you prefer I open up a separate PR and copy the original text from the official GitHub documentation into that one instead?

@kevinburkesegment

Copy link
Copy Markdown
ContributorAuthor

I believe I signed the CLA but if you're still not seeing it on your end please feel free to duplicate the work. I do not need credit, I'd just like it to be fixed so I don't make the same mistake 6 months from now. Thanks

@gmlewisgmlewis changed the title github: add doc for NewPullRequestAdd doc for NewPullRequestJul 16, 2024

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I signed the CLA but if you're still not seeing it on your end please feel free to duplicate the work. I do not need credit, I'd just like it to be fixed so I don't make the same mistake 6 months from now. Thanks

Excellent, thank you, @kevinburkesegment !
LGTM.
Merging.

@gmlewis
gmlewis merged commit 5f496dd into google:masterJul 16, 2024
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kevinburkesegment@gmlewis