Skip to content

feat!: Fix broken SCIMService.ProvisionAndInviteSCIMUser method - #3239

Merged
gmlewis merged 2 commits into
google:masterfrom
rezmoss:fix-3238
Aug 26, 2024
Merged

feat!: Fix broken SCIMService.ProvisionAndInviteSCIMUser method#3239
gmlewis merged 2 commits into
google:masterfrom
rezmoss:fix-3238

Conversation

@rezmoss

@rezmossrezmoss commented Aug 20, 2024

Copy link
Copy Markdown
Contributor

Fixes: #3238.

BREAKING CHANGE: SCIMService.ProvisionAndInviteSCIMUser now returns a response.

@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov

codecovBot commented Aug 21, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.95%. Comparing base (2b8c7fa) to head (02064f6).
Report is 103 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3239 +/- ##
==========================================
- Coverage 97.72% 92.95% -4.78% 
==========================================
Files 153 171 +18 Lines 13390 11647 -1743 ==========================================
- Hits 13085 10826 -2259 - Misses 215 727 +512 - Partials 90 94 +4 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewisgmlewis changed the title Fixed 3238feat!: Fix broken SCIMService.ProvisionAndInviteSCIMUser methodAug 21, 2024
@gmlewisgmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Aug 21, 2024

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @rezmoss !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@tomfeigintomfeigin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 26, 2024
@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @tomfeigin !
Merging.

@gmlewis
gmlewis merged commit 039fefd into google:masterAug 26, 2024
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
…le#3239)
Fixes: google#3238. BREAKING CHANGE: `SCIMService.ProvisionAndInviteSCIMUser` now returns a response.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ProvisionAndInviteSCIMUser query instead body

3 participants

@rezmoss@gmlewis@tomfeigin