Skip to content

feat: Add do_not_enforce_on_create to required status checks rule params - #3245

Merged
gmlewis merged 2 commits into
google:masterfrom
MattMencel:ruleset_do_not_enforce_on_create
Aug 22, 2024
Merged

feat: Add do_not_enforce_on_create to required status checks rule params#3245
gmlewis merged 2 commits into
google:masterfrom
MattMencel:ruleset_do_not_enforce_on_create

Conversation

@MattMencel

@MattMencelMattMencel commented Aug 22, 2024

Copy link
Copy Markdown
Contributor

Fixes: #3244.

I signed the CLA. The fmttest and lint scripts all passed without warnings.

@gmlewis

Copy link
Copy Markdown
Collaborator

I signed the CLA. The fmttest and lint scripts all passed without warnings.

It looks like GitHub Actions disagrees:

--- FAIL: TestRepositoryRule_UnmarshalJSON (0.01s)
--- FAIL: TestRepositoryRule_UnmarshalJSON/Valid_required_status_checks_params (0.00s)
repos_rules_test.go:287: RepositoryRule.UnmarshalJSON expected rule &{Type:required_status_checks Parameters:0xc0004208d0 RulesetSourceType: RulesetSource: RulesetID:0}, got &{Type:required_status_checks Parameters:0xc000420d20 RulesetSourceType: RulesetSource: RulesetID:0}

Can you please update this test and push the changes to this PR?
(There's no need to force-push in this repo because we always squash-and-merge each PR.)

Thank you, @MattMencel !

@MattMencel

Copy link
Copy Markdown
ContributorAuthor

I signed the CLA. The fmttest and lint scripts all passed without warnings.

It looks like GitHub Actions disagrees:

Whoopsies.... well they do now. 😄

@gmlewisgmlewis changed the title feat: add do_not_enforce_on_create to required status checks rule paramsfeat: Add do_not_enforce_on_create to required status checks rule paramsAug 22, 2024
@codecov

codecovBot commented Aug 22, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.95%. Comparing base (2b8c7fa) to head (5c88e6f).
Report is 101 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3245 +/- ##
==========================================
- Coverage 97.72% 92.95% -4.78% 
==========================================
Files 153 171 +18 Lines 13390 11646 -1744 ==========================================
- Hits 13085 10825 -2260 - Misses 215 727 +512 - Partials 90 94 +4 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @MattMencel !
LGTM.
Merging.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rulesets - do not require status checks on creation

2 participants

@MattMencel@gmlewis