Uh oh!
There was an error while loading. Please reload this page.
feat!: Fix meta service domains schema structure - #3249
Merged
Conversation
lrstanley
marked this pull request as draft
August 22, 2024 15:20
lrstanley
marked this pull request as ready for review
August 22, 2024 15:21
- closes#3248 Signed-off-by: Liam Stanley <liam@liam.sh>
gmlewis
commented
Aug 22, 2024
Collaborator
(No need to force-push PRs in this repo, @lrstanley - as we always squash and merge.) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #3249 +/- ##
==========================================
- Coverage 97.72% 92.95% -4.78%
==========================================
Files 153 171 +18 Lines 13390 11646 -1744 ==========================================
- Hits 13085 10825 -2260 - Misses 215 727 +512 - Partials 90 94 +4 ☔ View full report in Codecov by Sentry. |
gmlewis
approved these changes
Aug 22, 2024
gmlewis
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @lrstanley !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
gmlewis
commented
Aug 26, 2024
Collaborator
Thank you, @tomfeigin ! |
Closed
1 task
jlaportebot added a commit
to jlaportebot/go-github
that referenced
this pull request
Jun 28, 2026
Fixes: google#3248. BREAKING CHANGE: `APIMeta.Domains` changed from `map` to `struct`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3248.
BREAKING CHANGE:
APIMeta.Domainschanged frommaptostruct.This should at least be a tiny bit less prone to breaking, as it only accounts for existing schema with that API, and future additions should silently be ignored (unless GitHub breaks the contract, which they didn't really do in this scenario).
MetaService.Getfails because the schema of the JSON in the API response is different from the expected inAPIMeta.Domainstype #3248