Skip to content

Update active committers struct - #3257

Merged
gmlewis merged 4 commits into
google:masterfrom
ganeshkumarsv:CONTSEC-1503-update-active-committers
Sep 5, 2024
Merged

Update active committers struct#3257
gmlewis merged 4 commits into
google:masterfrom
ganeshkumarsv:CONTSEC-1503-update-active-committers

Conversation

@ganeshkumarsv

Copy link
Copy Markdown
Contributor

Update active committers struct to include additional attributes.

@codecov

codecovBot commented Sep 5, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.94%. Comparing base (2b8c7fa) to head (66567f8).
Report is 106 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3257 +/- ##
==========================================
- Coverage 97.72% 92.94% -4.78% 
==========================================
Files 153 171 +18 Lines 13390 11663 -1727 ==========================================
- Hits 13085 10840 -2245 - Misses 215 729 +514 - Partials 90 94 +4 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ganeshkumarsv

Copy link
Copy Markdown
ContributorAuthor

@gmlewis can you please take a look when you have time? I added all the introduced attributes into the test case, I'm not sure why the code coverage still fails.

@gmlewis

Copy link
Copy Markdown
Collaborator

@gmlewis can you please take a look when you have time? I added all the introduced attributes into the test case, I'm not sure why the code coverage still fails.

Thank you, @ganeshkumarsv !
Yes, we currently have an issue with CodeCov where we need the token in this repo to be updated for it to work again.
For details, see: #3221

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ganeshkumarsv !
LGTM.
Merging.

@gmlewis
gmlewis merged commit bd3e889 into google:masterSep 5, 2024
@ganeshkumarsv

Copy link
Copy Markdown
ContributorAuthor

Thank you for merging @gmlewis 🙇. Is it possible to create a new release?

@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you for merging @gmlewis 🙇. Is it possible to create a new release?

Our next release will probably be in a couple weeks.

@gmlewis

Copy link
Copy Markdown
Collaborator

This has now been released: https://github.com/google/go-github/releases/tag/v65.0.0

jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ganeshkumarsv@gmlewis