Skip to content

chore: Change golangci-lint output format due to deprecation - #3279

Merged
gmlewis merged 1 commit into
google:masterfrom
felixlut:patch-1
Sep 21, 2024
Merged

chore: Change golangci-lint output format due to deprecation#3279
gmlewis merged 1 commit into
google:masterfrom
felixlut:patch-1

Conversation

@felixlut

@felixlutfelixlut commented Sep 21, 2024

Copy link
Copy Markdown
Contributor

As specified in the GitHub Actions logs for the linter, the github-actions output format is deprecated, and colored-line-number should be used instead. Deprecation was done in golangci/golangci-lint#4726

github-actions is deprecated, and colored-line-number should be used instead
@gmlewisgmlewis changed the title chore: change golangci-lint output format due to deprecationchore: Change golangci-lint output format due to deprecationSep 21, 2024
@codecov

codecovBot commented Sep 21, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.94%. Comparing base (2b8c7fa) to head (2256497).
Report is 116 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3279 +/- ##
==========================================
- Coverage 97.72% 92.94% -4.78% 
==========================================
Files 153 171 +18 Lines 13390 11669 -1721 ==========================================
- Hits 13085 10846 -2239 - Misses 215 729 +514 - Partials 90 94 +4 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @felixlut !
LGTM.
Merging.

@gmlewis
gmlewis merged commit 46f1127 into google:masterSep 21, 2024
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@felixlut@gmlewis