Skip to content

feat: Support baseRole option for custom organization roles - #3284

Merged
gmlewis merged 2 commits into
google:masterfrom
felixlut:custom-org-role-base-role
Sep 22, 2024
Merged

feat: Support baseRole option for custom organization roles#3284
gmlewis merged 2 commits into
google:masterfrom
felixlut:custom-org-role-base-role

Conversation

@felixlut

@felixlutfelixlut commented Sep 22, 2024

Copy link
Copy Markdown
Contributor

@felixlut
felixlut marked this pull request as ready for review September 22, 2024 14:21
@felixlutfelixlut changed the title support baseRole option for custom organization rolesfeat: Support baseRole option for custom organization rolesSep 22, 2024
@gmlewis

Copy link
Copy Markdown
Collaborator

Please run step 4 of CONTRIBUTING.md and push the changes to this PR for the tests to pass.

@codecov

codecovBot commented Sep 22, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.94%. Comparing base (2b8c7fa) to head (b86c354).
Report is 117 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3284 +/- ##
==========================================
- Coverage 97.72% 92.94% -4.78% 
==========================================
Files 153 171 +18 Lines 13390 11669 -1721 ==========================================
- Hits 13085 10846 -2239 - Misses 215 729 +514 - Partials 90 94 +4 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @felixlut !
LGTM.
Merging.

@gmlewis
gmlewis merged commit 63c97e6 into google:masterSep 22, 2024
@felixlut
felixlut deleted the custom-org-role-base-role branch September 23, 2024 15:08
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Support creating an organization role with base role

2 participants

@felixlut@gmlewis