Uh oh!
There was an error while loading. Please reload this page.
refactor: Do not call teardown manually in tests - #3293
Conversation
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @alexandear !
One important change, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.
Uh oh!
There was an error while loading. Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #3293 +/- ##
==========================================
- Coverage 97.72% 92.97% -4.75%
==========================================
Files 153 171 +18 Lines 13390 11715 -1675 ==========================================
- Hits 13085 10892 -2193 - Misses 215 729 +514 - Partials 90 94 +4 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @alexandear !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
gmlewis
commented
Oct 1, 2024
Thank you, @tomfeigin ! |
The PR refactors the
setupfunction by passing*testing.Tparameter and callingt.Cleanup(server.Close)inside. So a test that usingsetupdoesn't need to call manuallyteardown.This leads to removal of 1319 code lines in tests.