Skip to content

Add t.Parallel to unit tests - #3297

Merged
gmlewis merged 3 commits into
google:masterfrom
gmlewis:parallel-tests
Oct 5, 2024
Merged

Add t.Parallel to unit tests#3297
gmlewis merged 3 commits into
google:masterfrom
gmlewis:parallel-tests

Conversation

@gmlewis

@gmlewisgmlewis commented Oct 1, 2024

Copy link
Copy Markdown
Collaborator

On my system, this cuts testing time by approximately half.

@gmlewis
Add t.Parallel to unit tests
d69e822
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Oct 1, 2024
@codecov

codecovBot commented Oct 1, 2024•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.05%. Comparing base (2b8c7fa) to head (2a5e218).
Report is 135 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3297 +/- ##
==========================================
- Coverage 97.72% 93.05% -4.67% 
==========================================
Files 153 172 +19 Lines 13390 11772 -1618 ==========================================
- Hits 13085 10955 -2130 - Misses 215 723 +508 - Partials 90 94 +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis

gmlewis commented Oct 3, 2024

Copy link
Copy Markdown
CollaboratorAuthor

@alexandear - might you have time to review this PR, please?

alexandear
alexandear reviewed Oct 4, 2024
View reviewed changes
Comment threadgithub/actions_artifacts_test.go
Comment threadgithub/actions_cache_test.go
alexandear
alexandear reviewed Oct 4, 2024
View reviewed changes
Comment threadtest/integration/activity_test.go
@gmlewis
Address review feedback
25b8aa3
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
alexandear
alexandear approved these changes Oct 5, 2024
View reviewed changes

@alexandearalexandear left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadtools/metadata/main_test.go Outdated
@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Oct 5, 2024
@gmlewis
Address review feedback
2a5e218
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis
gmlewis merged commit dc884c2 into google:masterOct 5, 2024
@gmlewis
gmlewis deleted the parallel-tests branch October 5, 2024 11:29
@gmlewisgmlewis mentioned this pull request Oct 6, 2024
Merged
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
@jlaportebot
Add t.Parallel to unit tests (google#3297)
f794a85
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@alexandearalexandearalexandear approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gmlewis@alexandear