Uh oh!
There was an error while loading. Please reload this page.
fix: Add missing NotificationSetting to newTeamNoParent - #3302
Merged
gmlewis merged 2 commits intoOct 4, 2024
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #3302 +/- ##
==========================================
- Coverage 97.72% 93.05% -4.67%
==========================================
Files 153 172 +19 Lines 13390 11772 -1618 ==========================================
- Hits 13085 10955 -2130 - Misses 215 723 +508 - Partials 90 94 +4 ☔ View full report in Codecov by Sentry. |
gmlewis
requested changes
Oct 3, 2024
gmlewis
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @alexandear !
One minor tweak, please.
Uh oh!
There was an error while loading. Please reload this page.
gmlewis
approved these changes
Oct 4, 2024
gmlewis
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @alexandear !
LGTM.
Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
newTeamNoParentstruct is the same asNewTeamas the comment states. The PR #3111 addedNotificationSettingfield to theNewTeambut forgot to add it to thenewTeamNoParent.