Skip to content

refactor: Remove redundant local vars in examples - #3303

Merged
gmlewis merged 1 commit into
google:masterfrom
alexandear-org:refactor/example-redundant-vars
Oct 3, 2024
Merged

refactor: Remove redundant local vars in examples#3303
gmlewis merged 1 commit into
google:masterfrom
alexandear-org:refactor/example-redundant-vars

Conversation

@alexandear

@alexandearalexandear commented Oct 3, 2024

Copy link
Copy Markdown
Contributor

The PR proposes removing local variables such as bytePassword and secretBytes because they do not significantly enhance readability.

@codecov

codecovBot commented Oct 3, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 93.05%. Comparing base (2b8c7fa) to head (cbdcbef).
Report is 131 commits behind head on master.

Files with missing linesPatch %Lines
example/basicauth/main.go0.00%2 Missing ⚠️
example/tagprotection/main.go0.00%2 Missing ⚠️
example/tokenauth/main.go0.00%2 Missing ⚠️
...xample/codespaces/newreposecretwithxcrypto/main.go0.00%1 Missing ⚠️
...xample/codespaces/newusersecretwithxcrypto/main.go0.00%1 Missing ⚠️
example/newreposecretwithxcrypto/main.go0.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #3303 +/- ##
==========================================
- Coverage 97.72% 93.05% -4.67% 
==========================================
Files 153 172 +19 Lines 13390 11771 -1619 ==========================================
- Hits 13085 10954 -2131 - Misses 215 723 +508 - Partials 90 94 +4 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexandear !
LGTM.
Merging.

@gmlewis
gmlewis merged commit c0f593d into google:masterOct 3, 2024
@alexandear
alexandear deleted the refactor/example-redundant-vars branch October 4, 2024 07:37
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alexandear@gmlewis