Skip to content

feat: Add CreatedAt and UpdatedAt to Ruleset - #3316

Merged
gmlewis merged 3 commits into
google:masterfrom
ivanmartos:feat/exposeCreatedAtUpdatedAtRuleset
Oct 8, 2024
Merged

feat: Add CreatedAt and UpdatedAt to Ruleset#3316
gmlewis merged 3 commits into
google:masterfrom
ivanmartos:feat/exposeCreatedAtUpdatedAtRuleset

Conversation

@ivanmartos

Copy link
Copy Markdown
Contributor

This PR will expose fields CreatedAt and UpdatedAt for Ruleset

Closes#3315

@google-cla

google-claBot commented Oct 8, 2024

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewisgmlewis changed the title feat: export createdAt and updatedAt for rulesetfeat: Add CreatedAt and UpdatedAt to RulesetOct 8, 2024

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ivanmartos !
Please run go generate ./... and push (not force-push) the changes to this PR as explained in step 4 of CONTRIBUTING.md.

@codecov

codecovBot commented Oct 8, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.05%. Comparing base (2b8c7fa) to head (8f11111).
Report is 143 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3316 +/- ##
==========================================
- Coverage 97.72% 93.05% -4.67% 
==========================================
Files 153 172 +19 Lines 13390 11760 -1630 ==========================================
- Hits 13085 10943 -2142 - Misses 215 723 +508 - Partials 90 94 +4 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ivanmartos !
LGTM.
Merging.

@gmlewis
gmlewis merged commit 13afa20 into google:masterOct 8, 2024
@ivanmartos
ivanmartos deleted the feat/exposeCreatedAtUpdatedAtRuleset branch October 22, 2024 13:57
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: expose CreatedAt and UpdatedAt from ruleset

2 participants

@ivanmartos@gmlewis