Skip to content

refactor: Replace 'print' with 'fmt.Print' - #3327

Merged
gmlewis merged 1 commit into
google:masterfrom
alexandear-org:refactor/replace-print-with-fmt
Oct 14, 2024
Merged

refactor: Replace 'print' with 'fmt.Print'#3327
gmlewis merged 1 commit into
google:masterfrom
alexandear-org:refactor/replace-print-with-fmt

Conversation

@alexandear

@alexandearalexandear commented Oct 14, 2024

Copy link
Copy Markdown
Contributor

The PR replaces print with normal fmt.Print in the test directory.

print is not guaranteed to stay in the language according to the spec.

These changes are similar to those in #3326.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexandear !
LGTM.
Merging.

@codecov

codecovBot commented Oct 14, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.39%. Comparing base (2b8c7fa) to head (5ab40ba).
Report is 153 commits behind head on master.

Files with missing linesPatch %Lines
test/fields/fields.go0.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #3327 +/- ##
==========================================
- Coverage 97.72% 93.39% -4.33% 
==========================================
Files 153 172 +19 Lines 13390 11909 -1481 ==========================================
- Hits 13085 11123 -1962 - Misses 215 692 +477 - Partials 90 94 +4 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis
gmlewis merged commit 8ea16b9 into google:masterOct 14, 2024
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alexandear@gmlewis