Uh oh!
There was an error while loading. Please reload this page.
feat!: Add name query parameter to ActionsService.ListArtifacts - #3330
Merged
Conversation
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #3330 +/- ##
==========================================
- Coverage 97.72% 93.01% -4.71%
==========================================
Files 153 172 +19 Lines 13390 14848 +1458 ==========================================
+ Hits 13085 13811 +726 - Misses 215 944 +729 - Partials 90 93 +3 ☔ View full report in Codecov by Sentry. |
gmlewis
commented
Oct 21, 2024
CollaboratorAuthor
@muhardanz - can you please take a look at this (and possibly try it out) to see if it fixes the issue you were having? |
muhardanz
commented
Oct 21, 2024
@gmlewis I can confirm that this fixes the ListArtifacts function so that it can take in the name query string. I can also confirm that it returns the correct result |
gmlewis
commented
Oct 21, 2024
CollaboratorAuthor
Thank you, @muhardanz ! |
1 task
jlaportebot added a commit
to jlaportebot/go-github
that referenced
this pull request
Jun 28, 2026
…le#3330) Fixes: google#3328. BREAKING CHANGE: `opts` argument to `ActionsService.ListArtifacts` changed from `ListOptions` to `ListArtifactsOptions`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3328.
BREAKING CHANGE:
optsargument toActionsService.ListArtifactschanged fromListOptionstoListArtifactsOptions.