Uh oh!
There was an error while loading. Please reload this page.
Add support for fetching artifact attestations at the org, repo and user level - #3334
Conversation
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @gillisandrew!
A few questions and tweaks, please.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## master #3334 +/- ##
==========================================
- Coverage 97.72% 92.29% -5.43%
==========================================
Files 153 176 +23 Lines 13390 15019 +1629 ==========================================
+ Hits 13085 13862 +777 - Misses 215 1064 +849 - Partials 90 93 +3 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @gillisandrew .
Please add unit tests for the newly-added methods.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @gillisandrew !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
gillisandrew
commented
Oct 25, 2024
@gmlewis Great! Thanks for your help and feedback, really appreciate it. |
gmlewis
commented
Oct 27, 2024
Thank you, @tomfeigin ! |
GitHub artifact attestations is now generally available
This pull request adds support for listing attestations hosted on GitHub for a given subject digest. Those attestations can then be verified using another library such as sigstore-go. I've included a basic demo as an example.