Skip to content

Add support for fetching artifact attestations at the org, repo and user level - #3334

Merged
gmlewis merged 13 commits into
google:masterfrom
gillisandrew:feat-attestations
Oct 27, 2024
Merged

Add support for fetching artifact attestations at the org, repo and user level#3334
gmlewis merged 13 commits into
google:masterfrom
gillisandrew:feat-attestations

Conversation

@gillisandrew

Copy link
Copy Markdown
Contributor

GitHub artifact attestations is now generally available

This pull request adds support for listing attestations hosted on GitHub for a given subject digest. Those attestations can then be verified using another library such as sigstore-go. I've included a basic demo as an example.

@gmlewisgmlewis changed the title add support for fetching artifact attestations at the org, repo and user levelAdd support for fetching artifact attestations at the org, repo and user levelOct 24, 2024

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @gillisandrew!
A few questions and tweaks, please.

Comment threadexample/go.mod
Comment threadexample/verifyartifact/main.go Outdated
Comment threadexample/verifyartifact/main.go Outdated
Comment threadgithub/attestations.go
Comment threadgithub/attestations.go Outdated
Comment threadgithub/attestations.go
@codecov

codecovBot commented Oct 24, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 29.82456% with 120 lines in your changes missing coverage. Please review.

Project coverage is 92.29%. Comparing base (2b8c7fa) to head (c1900ae).
Report is 159 commits behind head on master.

Files with missing linesPatch %Lines
example/verifyartifact/main.go0.00%120 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #3334 +/- ##
==========================================
- Coverage 97.72% 92.29% -5.43% 
==========================================
Files 153 176 +23 Lines 13390 15019 +1629 ==========================================
+ Hits 13085 13862 +777 - Misses 215 1064 +849 - Partials 90 93 +3 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @gillisandrew .
Please add unit tests for the newly-added methods.

Comment threadexample/verifyartifact/main.go Outdated
Comment threadgithub/attestations.go Outdated
gillisandrewand others added 5 commits October 25, 2024 10:24
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Comment threadgithub/orgs_attestations_test.go
gillisandrewand others added 2 commits October 25, 2024 13:57
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @gillisandrew !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Oct 25, 2024
@gillisandrew

Copy link
Copy Markdown
ContributorAuthor

@gmlewis Great! Thanks for your help and feedback, really appreciate it.

@tomfeigintomfeigin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Oct 27, 2024
@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @tomfeigin !
Merging.

@gmlewis
gmlewis merged commit 08cca48 into google:masterOct 27, 2024
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@gillisandrew@gmlewis@tomfeigin