Skip to content

Add missing Deployment field to workflow_job event type - #3353

Merged
gmlewis merged 1 commit into
google:masterfrom
AirOne70:master
Nov 20, 2024
Merged

Add missing Deployment field to workflow_job event type#3353
gmlewis merged 1 commit into
google:masterfrom
AirOne70:master

Conversation

@AirOne70

Copy link
Copy Markdown
Contributor

The workflow_job webhook event as described by GitHub documentation contains a deployment object.
https://docs.github.com/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#workflow_job

However, the struct that defines the workflow_job webhook event type is missing the deployment object . This PR adds the missing object to the WorkflowJobEvent type.

@codecov

codecovBot commented Nov 20, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.30%. Comparing base (2b8c7fa) to head (dc752c2).
Report is 174 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3353 +/- ##
==========================================
- Coverage 97.72% 92.30% -5.42% 
==========================================
Files 153 176 +23 Lines 13390 15031 +1641 ==========================================
+ Hits 13085 13874 +789 - Misses 215 1064 +849 - Partials 90 93 +3 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @AirOne70 !
LGTM.
Merging.

@gmlewis
gmlewis merged commit 6d30edd into google:masterNov 20, 2024
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AirOne70@gmlewis