Skip to content

feat!: Remove Project (classic) support - #3380

Merged
gmlewis merged 2 commits into
google:masterfrom
gmlewis:i3367-remove-projects
Dec 11, 2024
Merged

feat!: Remove Project (classic) support#3380
gmlewis merged 2 commits into
google:masterfrom
gmlewis:i3367-remove-projects

Conversation

@gmlewis

@gmlewisgmlewis commented Dec 10, 2024

Copy link
Copy Markdown
Collaborator

BREAKING CHANGE: All support for "Project (classic)" is removed and Project responses are replaced by ProjectV2 (renamed from ProjectsV2).

Fixes: #3367.

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@codecov

codecovBot commented Dec 10, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.17%. Comparing base (2b8c7fa) to head (4757698).
Report is 195 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3380 +/- ##
==========================================
- Coverage 97.72% 92.17% -5.55% 
==========================================
Files 153 172 +19 Lines 13390 14704 +1314 ==========================================
+ Hits 13085 13554 +469 - Misses 215 1060 +845 
Partials 90 90 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewisgmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Dec 10, 2024

@stevehipwellstevehipwell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis

Copy link
Copy Markdown
CollaboratorAuthor

Thank you, @stevehipwell !

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@tomfeigintomfeigin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Dec 11, 2024
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis

Copy link
Copy Markdown
CollaboratorAuthor

Thank you, @tomfeigin !
Merging.

@gmlewis
gmlewis merged commit 550ecbe into google:masterDec 11, 2024
@gmlewis
gmlewis deleted the i3367-remove-projects branch December 11, 2024 13:45
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
BREAKING CHANGE: All support for "Project (classic)" is removed and `Project` responses are replaced by `ProjectV2` (renamed from `ProjectsV2`).
Fixes: google#3367.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove projects as the REST API for these is no longer available

3 participants

@gmlewis@stevehipwell@tomfeigin