Skip to content

chore: Remove commented out test code - #3381

Merged
gmlewis merged 1 commit into
google:masterfrom
alexandear-org:chore/remove-commented-test
Dec 11, 2024
Merged

chore: Remove commented out test code#3381
gmlewis merged 1 commit into
google:masterfrom
alexandear-org:chore/remove-commented-test

Conversation

@alexandear

Copy link
Copy Markdown
Contributor

The PR removes duplicated commented TestActionsService_ListSelectedReposForOrgSecret. This test is already present here:

funcTestActionsService_ListSelectedReposForOrgSecret(t*testing.T) {
t.Parallel()
client, mux, _:=setup(t)
mux.HandleFunc("/orgs/o/actions/secrets/NAME/repositories", func(w http.ResponseWriter, r*http.Request) {
testMethod(t, r, "GET")

Note: In the future, better to mark a test with t.Skip instead of commenting.

@alexandearalexandear changed the title chore: remove commented out test codechore: Remove commented out test codeDec 11, 2024

@stevehipwellstevehipwell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov

codecovBot commented Dec 11, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.27%. Comparing base (2b8c7fa) to head (9895b8b).
Report is 196 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3381 +/- ##
==========================================
- Coverage 97.72% 92.27% -5.45% 
==========================================
Files 153 176 +23 Lines 13390 15033 +1643 ==========================================
+ Hits 13085 13872 +787 - Misses 215 1068 +853 - Partials 90 93 +3 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexandear and @stevehipwell !
LGTM.
Merging.

@gmlewis
gmlewis merged commit c7f49d2 into google:masterDec 11, 2024
@alexandear
alexandear deleted the chore/remove-commented-test branch December 11, 2024 14:06
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@alexandear@stevehipwell@gmlewis