Skip to content

feat: Add enterprise custom properties - #3382

Merged
gmlewis merged 1 commit into
google:masterfrom
stevehipwell:add-enterprise-properties
Dec 12, 2024
Merged

feat: Add enterprise custom properties#3382
gmlewis merged 1 commit into
google:masterfrom
stevehipwell:add-enterprise-properties

Conversation

@stevehipwell

Copy link
Copy Markdown
Contributor

This PR adds enterprise scoped custom properties.

Note

This API endpoint is currently still in preview.

Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@gmlewisgmlewis changed the title feat: Added enterprise custom propertiesfeat: Add enterprise custom propertiesDec 11, 2024
@codecov

codecovBot commented Dec 11, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.31%. Comparing base (2b8c7fa) to head (741a8db).
Report is 198 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3382 +/- ##
==========================================
- Coverage 97.72% 92.31% -5.42% 
==========================================
Files 153 177 +24 Lines 13390 15099 +1709 ==========================================
+ Hits 13085 13938 +853 - Misses 215 1068 +853 - Partials 90 93 +3 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @stevehipwell - this looks great!
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Dec 11, 2024

@tomfeigintomfeigin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Dec 12, 2024
@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @tomfeigin !
Merging.

@gmlewis
gmlewis merged commit 7bc4871 into google:masterDec 12, 2024
@stevehipwell
stevehipwell deleted the add-enterprise-properties branch December 12, 2024 14:49
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@stevehipwell@gmlewis@tomfeigin