Uh oh!
There was an error while loading. Please reload this page.
docs: Add clarifications for mergeable field in pull requests - #3396
Conversation
Uh oh!
There was an error while loading. Please reload this page.
d505fe2 to
ca738b7Compareacouvreur
commented
Dec 27, 2024
It is now one single block comment @gmlewis |
gmlewis
commented
Dec 27, 2024
Please run the scripts listed in step 4 of CONTRIBUTING.md and push the changes. That should fix the linter and tests. |
gmlewis
commented
Jan 22, 2025
I will close this PR around the end of January, 2025 as "abandoned" if there is no further response. |
ca738b7 to
dd2c798Compareacouvreur
commented
Jan 30, 2025
Done just in time :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #3396 +/- ##
=======================================
Coverage 91.03% 91.03% =======================================
Files 179 179 Lines 15535 15535 =======================================
Hits 14142 14142 Misses 1221 1221 Partials 172 172 ☔ View full report in Codecov by Sentry. |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @acouvreur !
LGTM.
Merging.
Comparing the OpenAPI spec for pull requests shows that these fields are not populated when listing (right), but they are through GET or webhook:

In their OpenAPI Spec they have
pull-requestandpull-request-simpledefinitions.I think that would make sense to also have these structs instead of relying on comments for contextual field population.