Skip to content

docs: Add clarifications for mergeable field in pull requests - #3396

Merged
gmlewis merged 3 commits into
google:masterfrom
acouvreur:add-mergeable-clarifications
Jan 30, 2025
Merged

docs: Add clarifications for mergeable field in pull requests#3396
gmlewis merged 3 commits into
google:masterfrom
acouvreur:add-mergeable-clarifications

Conversation

@acouvreur

Copy link
Copy Markdown
Contributor

Comparing the OpenAPI spec for pull requests shows that these fields are not populated when listing (right), but they are through GET or webhook:
image

In their OpenAPI Spec they have pull-request and pull-request-simple definitions.

I think that would make sense to also have these structs instead of relying on comments for contextual field population.

@gmlewisgmlewis changed the title docs: add clarifications for mergeable field in pull requestsdocs: Add clarifications for mergeable field in pull requestsDec 21, 2024
Comment threadgithub/pulls.go Outdated
@acouvreur
acouvreurforce-pushed the add-mergeable-clarifications branch from d505fe2 to ca738b7CompareDecember 27, 2024 18:12
@acouvreur

Copy link
Copy Markdown
ContributorAuthor

It is now one single block comment @gmlewis

@gmlewis

Copy link
Copy Markdown
Collaborator

Please run the scripts listed in step 4 of CONTRIBUTING.md and push the changes. That should fix the linter and tests.

@gmlewis

Copy link
Copy Markdown
Collaborator

I will close this PR around the end of January, 2025 as "abandoned" if there is no further response.

@acouvreur
acouvreurforce-pushed the add-mergeable-clarifications branch from ca738b7 to dd2c798CompareJanuary 30, 2025 15:05
@acouvreur

Copy link
Copy Markdown
ContributorAuthor

I will close this PR around the end of January, 2025 as "abandoned" if there is no further response.

Done just in time :)

@codecov

codecovBot commented Jan 30, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.03%. Comparing base (7783310) to head (dd2c798).
Report is 1 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3396 +/- ##
=======================================
Coverage 91.03% 91.03% =======================================
Files 179 179 Lines 15535 15535 =======================================
Hits 14142 14142 Misses 1221 1221 Partials 172 172 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @acouvreur !
LGTM.
Merging.

@gmlewis
gmlewis merged commit cbe65f0 into google:masterJan 30, 2025
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@acouvreur@gmlewis