Skip to content

Update PersonalAccessToken struct - #3404

Merged
gmlewis merged 2 commits into
google:masterfrom
R4vio:feature/PAT-fields
Dec 25, 2024
Merged

Update PersonalAccessToken struct#3404
gmlewis merged 2 commits into
google:masterfrom
R4vio:feature/PAT-fields

Conversation

@R4vio

Copy link
Copy Markdown
Contributor

According to REST API: https://docs.github.com/en/rest/orgs/personal-access-tokens?apiVersion=2022-11-28#list-fine-grained-personal-access-tokens-with-access-to-organization-resources

There are some fields which are not getting captured by PersonalAccessToken struct. The fields are:

token_id
token_name

For issue: #3403

@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @R4vio !
LGTM.
Merging.

@codecov

codecovBot commented Dec 25, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.21%. Comparing base (2b8c7fa) to head (02a38b5).
Report is 209 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3404 +/- ##
==========================================
- Coverage 97.72% 92.21% -5.51% 
==========================================
Files 153 173 +20 Lines 13390 14770 +1380 ==========================================
+ Hits 13085 13620 +535 - Misses 215 1060 +845 
Partials 90 90 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis

Copy link
Copy Markdown
Collaborator

@R4vio - please run step 4 in CONTRIBUTING.md and push the changes. (go generate ./...)

@R4vio

Copy link
Copy Markdown
ContributorAuthor

@gmlewis, did the steps in CONTRIBUTING.md, seems it was missing some accessors.

@gmlewis
gmlewis merged commit 3424b98 into google:masterDec 25, 2024
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@R4vio@gmlewis