Skip to content

Add deprecation messages to security managers APIs - #3426

Merged
gmlewis merged 1 commit into
google:masterfrom
just-joshing:master
Jan 7, 2025
Merged

Add deprecation messages to security managers APIs#3426
gmlewis merged 1 commit into
google:masterfrom
just-joshing:master

Conversation

@just-joshing

Copy link
Copy Markdown
Contributor

The organization security manager role REST APIs are being sunset (https://gh.io/security-managers-rest-api-sunset) in favor of the organization roles REST APIs.

This change adds deprecation messages to tell consumers which client operations to use instead going forward.

@just-joshing

Copy link
Copy Markdown
ContributorAuthor

I had previously tried updating these operations instead to use the replacement client methods under-the-hood but got feedback to go the deprecation route instead.

@stevehipwellstevehipwell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @just-joshing and @stevehipwell !
LGTM.
Merging.

@codecov

codecovBot commented Jan 7, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.22%. Comparing base (2b8c7fa) to head (9f0b14d).
Report is 217 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3426 +/- ##
==========================================
- Coverage 97.72% 92.22% -5.51% 
==========================================
Files 153 173 +20 Lines 13390 14937 +1547 ==========================================
+ Hits 13085 13775 +690 - Misses 215 1068 +853 - Partials 90 94 +4 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@just-joshing@stevehipwell@gmlewis