Skip to content

Enforce toolchain requirement in generate.sh - #3428

Merged
gmlewis merged 1 commit into
google:masterfrom
gmlewis:enforce-toolchain-requirement
Jan 9, 2025
Merged

Enforce toolchain requirement in generate.sh#3428
gmlewis merged 1 commit into
google:masterfrom
gmlewis:enforce-toolchain-requirement

Conversation

@gmlewis

Copy link
Copy Markdown
Collaborator

@dnwe - does this seem like a reasonable change for the use of all developers in this repo?

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@codecov

codecovBot commented Jan 9, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.26%. Comparing base (2b8c7fa) to head (94df24b).
Report is 220 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #3428 +/- ##
==========================================
- Coverage 97.72% 92.26% -5.46% 
==========================================
Files 153 174 +21 Lines 13390 15023 +1633 ==========================================
+ Hits 13085 13861 +776 - Misses 215 1068 +853 - Partials 90 94 +4 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dnwe

dnwe commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

@gmlewis seems reasonable — an alternative would be to set toolchain directives in the go.mod files to the latest 1.22.x as the 'auto' default will pick that up too

@gmlewis

Copy link
Copy Markdown
CollaboratorAuthor

This seems like lower maintenance needed, so let's run with this for now.

@gmlewis
gmlewis merged commit 1343645 into google:masterJan 9, 2025
@gmlewis
gmlewis deleted the enforce-toolchain-requirement branch January 9, 2025 17:19
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@gmlewis@dnwe